Bug Summary

File:builds/wireshark/wireshark/ui/qt/extcap_argument_multiselect.cpp
Warning:line 122, column 20
Potential leak of memory pointed to by 'pane'

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple x86_64-pc-linux-gnu -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name extcap_argument_multiselect.cpp -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=cplusplus -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -fno-delete-null-pointer-checks -mframe-pointer=all -relaxed-aliasing -fmath-errno -ffp-contract=on -fno-rounding-math -ffloat16-excess-precision=fast -fbfloat16-excess-precision=fast -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/builds/wireshark/wireshark/build -fcoverage-compilation-dir=/builds/wireshark/wireshark/build -resource-dir /usr/lib/llvm-22/lib/clang/22 -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /builds/wireshark/wireshark/build/ui/qt -isystem /builds/wireshark/wireshark/ui/qt -isystem /builds/wireshark/wireshark/ui/qt/lua_debugger -isystem /usr/include/x86_64-linux-gnu/qt6/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt6 -isystem /usr/include/x86_64-linux-gnu/qt6/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt6/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt6/QtPrintSupport -isystem /usr/include/x86_64-linux-gnu/qt6/QtGui -isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt6/QtSvg -isystem /usr/include/x86_64-linux-gnu/qt6/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt6/QtDBus -D CARES_NO_DEPRECATED -D G_DISABLE_DEPRECATED -D G_DISABLE_SINGLE_INCLUDES -D QT_CONCURRENT_LIB -D QT_CORE_LIB -D QT_DBUS_LIB -D QT_GUI_LIB -D QT_MULTIMEDIA_LIB -D QT_NETWORK_LIB -D QT_PRINTSUPPORT_LIB -D QT_SVG_LIB -D QT_WIDGETS_LIB -D WS_DEBUG -D WS_DEBUG_UTF_8 -I /builds/wireshark/wireshark/build/ui/qt/qtui_autogen/include -I /builds/wireshark/wireshark/build -I /builds/wireshark/wireshark -I /builds/wireshark/wireshark/include -D _GLIBCXX_ASSERTIONS -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/16/../../../../include/c++/16 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/16/../../../../include/x86_64-linux-gnu/c++/16 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/16/../../../../include/c++/16/backward -internal-isystem /usr/lib/llvm-22/lib/clang/22/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/16/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -fmacro-prefix-map=/builds/wireshark/wireshark/= -fmacro-prefix-map=/builds/wireshark/wireshark/build/= -fmacro-prefix-map=../= -Wno-format-nonliteral -std=c++17 -fdeprecated-macro -ferror-limit 19 -fwrapv -fwrapv-pointer -fstrict-flex-arrays=3 -stack-protector 2 -fstack-clash-protection -fcf-protection=full -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fcolor-diagnostics -analyzer-output=html -faddrsig -fdwarf2-cfi-asm -o /builds/wireshark/wireshark/sbout/2026-10-23-100316-3661-1 -x c++ /builds/wireshark/wireshark/ui/qt/extcap_argument_multiselect.cpp
1/* extcap_argument_multiselect.cpp
2 *
3 * Wireshark - Network traffic analyzer
4 * By Gerald Combs <[email protected]>
5 * Copyright 1998 Gerald Combs
6 *
7 * SPDX-License-Identifier: GPL-2.0-or-later
8 */
9
10#include <extcap_argument.h>
11#include <extcap_argument_file.h>
12
13#include <wsutil/utf8_entities.h>
14
15#include <QLabel>
16#include <QLineEdit>
17#include <QBoxLayout>
18#include <QVariant>
19#include <QPushButton>
20#include <QMenu>
21#include <QHeaderView>
22#include <QInputDialog>
23#include <QToolButton>
24
25#include <ui/qt/utils/themes/themed_icon.h>
26#include <ui/qt/utils/theme_manager.h>
27
28#include <extcap.h>
29#include <extcap_parser.h>
30#include <extcap_argument_multiselect.h>
31#include "ui/capture_globals.h"
32
33ExtArgMultiSelect::ExtArgMultiSelect(extcap_arg * argument, QObject *parent) :
34 ExtcapArgument(argument, parent), viewModel(0), treeView(0) {}
35
36ExtArgMultiSelect::~ExtArgMultiSelect()
37{
38}
39
40// NOLINTNEXTLINE(misc-no-recursion)
41QList<QStandardItem *> ExtArgMultiSelect::valueWalker(ExtcapValueList list, QStringList &defaults)
42{
43 ExtcapValueList::iterator iter = list.begin();
44 QList<QStandardItem *> items;
45
46 while (iter != list.end())
47 {
48 QStandardItem * item = new QStandardItem((*iter).value());
49 if ((*iter).enabled() == false)
50 {
51 item->setCheckable(false);
52 }
53 else
54 {
55 item->setCheckable(true);
56 }
57
58 item->setData((*iter).call(), Qt::UserRole);
59 if ((*iter).isDefault())
60 defaults << (*iter).call();
61
62 displayNames[(*iter).call()] = (*iter).value();
63
64 item->setSelectable(false);
65 item->setEditable(false);
66 // We recurse here, but the tree is only two levels deep
67 QList<QStandardItem *> childs = valueWalker((*iter).children(), defaults);
68 if (childs.length() > 0)
69 item->appendRows(childs);
70
71 items << item;
72 ++iter;
73 }
74
75 return items;
76}
77
78// NOLINTNEXTLINE(misc-no-recursion)
79void ExtArgMultiSelect::checkItemsWalker(QStandardItem * item, QStringList defaults)
80{
81 QModelIndex index;
82
83 if (item->hasChildren())
84 {
85 for (int row = 0; row < item->rowCount(); row++)
86 {
87 QStandardItem * child = item->child(row);
88 if (child != 0)
89 {
90 // We recurse here, but the tree is only two levels deep
91 checkItemsWalker(child, defaults);
92 }
93 }
94 }
95
96 QString data = item->data(Qt::UserRole).toString();
97
98 if (defaults.contains(data))
99 {
100 item->setCheckState(Qt::Checked);
101 index = item->index();
102 while (index.isValid())
103 {
104 treeView->setExpanded(index, true);
105 index = index.parent();
106 }
107 } else if (item->isCheckable()) {
108 item->setCheckState(Qt::Unchecked);
109 }
110}
111
112QWidget * ExtArgMultiSelect::createEditor(QWidget * parent)
113{
114 QStringList checked;
115 QLineEdit* searchBox;
116 QVBoxLayout* layout;
117 TreeSortFilterProxyModel* tableProxyModel;
118 QWidget* pane = new QWidget(parent);
2
←
Memory is allocated
→
119
120 QList<QStandardItem *> items = valueWalker(values, checked);
121 if (items.length() == 0)
3
←
Assuming the condition is true
→
4
←
Taking true branch
→
122 return new QWidget();
5
←
Potential leak of memory pointed to by 'pane'
123
124 /* Value can be empty if no items are checked */
125 if (_argument->pref_valptr && (*_argument->pref_valptr))
126 {
127 checked = QString(*_argument->pref_valptr).split(",", Qt::SkipEmptyParts);
128 }
129
130 /* Source model : contains the data */
131 viewModel = new QStandardItemModel(this);
132 QList<QStandardItem *>::const_iterator iter = items.constBegin();
133 while (iter != items.constEnd())
134 {
135 viewModel->appendRow((*iter));
136 ++iter;
137 }
138
139 /* Proxy model : filters the data */
140 tableProxyModel = new TreeSortFilterProxyModel(this);
141 tableProxyModel->setSourceModel(viewModel);
142
143 searchBox = new QLineEdit();
144 searchBox->setClearButtonEnabled(true);
145 searchBox->setPlaceholderText("Search");
146
147 treeView = new QTreeView();
148 treeView->setModel(tableProxyModel);
149
150 /* Shows at minimum 6 entries at most desktops */
151 treeView->setMinimumHeight(100);
152 treeView->setHeaderHidden(true);
153 treeView->setSelectionMode(QAbstractItemView::ExtendedSelection);
154 treeView->setEditTriggers(QAbstractItemView::NoEditTriggers);
155 treeView->expandAll();
156
157 for (int row = 0; row < viewModel->rowCount(); row++)
158 checkItemsWalker(((QStandardItemModel*)viewModel)->item(row), checked);
159
160 connect(viewModel, &QStandardItemModel::itemChanged, this, &ExtArgMultiSelect::valueChanged);
161 connect(searchBox, &QLineEdit::textChanged, this, [tableProxyModel](const QString& text) {
162 tableProxyModel->setFilterRegularExpression(QRegularExpression(text, QRegularExpression::PatternOption::CaseInsensitiveOption));
163 });
164
165 layout = new QVBoxLayout(pane);
166 layout->addWidget(searchBox);
167 layout->addWidget(treeView);
168 pane->setLayout(layout);
169
170 return pane;
171}
172
173bool TreeSortFilterProxyModel::filterAcceptsRow(int sourceRow,
174 const QModelIndex& sourceParent) const
175{
176 /* Only apply filter on leaves. */
177 if (sourceModel()->hasChildren(sourceModel()->index(sourceRow, 0, sourceParent)))
178 return true;
179
180 return QSortFilterProxyModel::filterAcceptsRow(sourceRow, sourceParent);
181}
182
183QStringList ExtArgMultiSelect::checkedValues()
184{
185 if (viewModel == 0)
186 return QStringList();
187
188 QStringList result;
189 QModelIndexList checked = viewModel->match(viewModel->index(0, 0), Qt::CheckStateRole, Qt::Checked, -1, Qt::MatchExactly | Qt::MatchRecursive);
190 if (checked.size() <= 0)
191 return QStringList();
192
193 QModelIndexList::const_iterator iter = checked.constBegin();
194 while (iter != checked.constEnd())
195 {
196 QModelIndex index = (QModelIndex)(*iter);
197
198 result << viewModel->data(index, Qt::UserRole).toString();
199
200 ++iter;
201 }
202
203 return result;
204}
205
206QString ExtArgMultiSelect::value()
207{
208 return checkedValues().join(QString(','));
209}
210
211bool ExtArgMultiSelect::isValid()
212{
213 bool valid = true;
214
215 if (isRequired())
216 {
217 if (viewModel == 0)
218 valid = false;
219 else
220 {
221 QModelIndexList checked = viewModel->match(viewModel->index(0, 0), Qt::CheckStateRole, Qt::Checked, -1, Qt::MatchExactly | Qt::MatchRecursive);
222 if (checked.size() <= 0)
223 valid = false;
224 }
225 }
226
227 if (viewModel != 0)
228 ThemeManager::setValidationState(treeView, valid ? QString() : QStringLiteral("invalid")(QString(QtPrivate::qMakeStringPrivate(u"" "invalid"))));
229
230 return valid;
231}
232
233QString ExtArgMultiSelect::defaultValue()
234{
235 QStringList checked;
236
237 QList<QStandardItem *> items = valueWalker(values, checked);
238 qDeleteAll(items);
239
240 return checked.join(QString(','));
241}
242
243bool ExtArgMultiSelect::isSetDefaultValueSupported()
244{
245 return true;
246}
247
248void ExtArgMultiSelect::setDefaultValue()
249{
250 QStringList checked;
251
252 if (viewModel == 0)
253 return;
254
255 checked = defaultValue().split(",", Qt::SkipEmptyParts);
256 for (int row = 0; row < viewModel->rowCount(); row++)
257 checkItemsWalker(((QStandardItemModel*)viewModel)->item(row), checked);
258}
259
260ExtArgTable::ExtArgTable(extcap_arg* argument, QObject* parent) :
261 ExtArgMultiSelect(argument, parent), extcap_options_dialog(0), addDialog(0), tableViewModel(0), tableView(0), paneLayout(0), toolbar(0) {}
262
263ExtArgTable::~ExtArgTable()
264{
265 // dialog is freed by its parent QWidget
266 if (tableView != 0)
267 delete tableView;
268 if (tableViewModel != 0)
269 delete tableViewModel;
270 if (toolbar != 0)
271 delete toolbar;
272 if (paneLayout != 0)
273 delete paneLayout;
274}
275
276ExtArgTableAddDialog::ExtArgTableAddDialog(QWidget* parent, QWidget* selector) : QDialog(parent)
277{
278 setWindowTitle("Add element");
279 setMinimumWidth(400);
280
281 QVBoxLayout* layout = new QVBoxLayout(this);
282 QPushButton* okButton = new QPushButton("OK", this);
283 QPushButton* cancelButton = new QPushButton("Cancel", this);
284
285 layout->addWidget(selector);
286 layout->addWidget(okButton);
287 layout->addWidget(cancelButton);
288
289 connect(okButton, &QPushButton::clicked, this, &QDialog::accept);
290 connect(cancelButton, &QPushButton::clicked, this, &QDialog::reject);
291}
292
293QWidget* ExtArgTable::createEditor(QWidget* parent)
294{
295 // The wrapper widget we return
296 QWidget* pane = new QWidget(parent);
297 paneLayout = new QVBoxLayout(pane);
298
299 // Create dialog
300 QWidget* treeViewWidget = ExtArgMultiSelect::createEditor(addDialog);
1
Calling 'ExtArgMultiSelect::createEditor'
→
301 addDialog = new ExtArgTableAddDialog(parent, treeViewWidget);
302
303 // Instantiate the menu bar
304 toolbar = new QToolBar(pane);
305 toolbar->setStyleSheet("QToolBar { border: 1px solid gray; border-radius: 3px; }");
306 QAction* addAction = toolbar->addAction("Add");
307 QAction* addActionCustom = toolbar->addAction("Add custom");
308 QAction* removeAction = toolbar->addAction("Remove");
309 paneLayout->addWidget(toolbar);
310
311 // Instantiate empty table
312 tableView = new QTableView(pane);
313 tableView->setMinimumHeight(200);
314 tableView->setSelectionMode(QAbstractItemView::ExtendedSelection);
315 tableView->setEditTriggers(QAbstractItemView::NoEditTriggers);
316 tableView->verticalHeader()->hide();
317 tableView->horizontalHeader()->hide();
318
319 tableViewModel = new QStandardItemModel(pane);
320 tableView->setModel(tableViewModel);
321 paneLayout->addWidget(tableView);
322
323 /* Value can be empty if no items are checked */
324 if (_argument->pref_valptr && (*_argument->pref_valptr))
325 {
326 QStringList checked;
327 QStringList options;
328
329 if (_argument->prefix)
330 {
331 QStringList splitted = QString(*_argument->pref_valptr).split(_argument->prefix, Qt::SkipEmptyParts);
332 QStringList parts;
333 for (QString item : splitted)
334 {
335 parts = item.split(" ", Qt::SkipEmptyParts);
336 checked << parts.takeFirst();
337 options << parts.join(" ");
338 }
339 }
340 else
341 {
342 checked = QString(*_argument->pref_valptr).split(" ", Qt::SkipEmptyParts);
343 }
344 addChecked(checked, options);
345 }
346
347 // Add handler for click
348 connect(addAction, &QAction::triggered, this, &ExtArgTable::addKnown);
349 connect(addActionCustom, &QAction::triggered, this, &ExtArgTable::addCustom);
350 connect(removeAction, &QAction::triggered, this, &ExtArgTable::removeSelected);
351 return pane;
352}
353
354QString ExtArgTable::value()
355{
356 QStringList results;
357 for (int row = 0; row < tableViewModel->rowCount(); row++) {
358 QString s = ((QStandardItemModel*)tableViewModel)->item(row)->data(Qt::UserRole).toString();
359 QString config = ((QStandardItemModel*)tableViewModel)->item(row)->data(Qt::UserRole + 1).toString();
360 if (_argument->prefix != NULL__null)
361 {
362 s.prepend(" ");
363 s.prepend(_argument->prefix);
364 }
365 if (!config.isEmpty())
366 {
367 s.append(" ");
368 s.append(config);
369 }
370 results << s;
371 }
372 return results.join(" ");
373}
374
375void ExtArgTable::addChecked(QStringList checked, QStringList options)
376{
377 for (int i = 0; i < checked.size(); ++i) {
378 QStandardItem* item = new QStandardItem(checked[i]);
379 item->setData(checked[i], Qt::UserRole);
380 if (displayNames.contains(checked[i]))
381 {
382 item->setText(displayNames[checked[i]]);
383 }
384
385 if (_argument->configurable)
386 {
387 if (options.size() > i)
388 {
389 item->setData(QString(options[i]), Qt::UserRole + 1); // Currently: has configuration
390 }
391 else
392 {
393 item->setData(QString(), Qt::UserRole + 1); // Currently: no configuration
394 }
395
396 QStandardItem* btnItem = new QStandardItem();
397 tableViewModel->appendRow({ item, btnItem });
398
399 // Add button
400 QToolButton* settingsButton = new QToolButton(tableView);
401 settingsButton->setIcon(ThemedIcon("capture-options"));
402 settingsButton->setFixedWidth(30);
403 tableView->setIndexWidget(tableViewModel->indexFromItem(btnItem), settingsButton);
404
405 connect(settingsButton, &QToolButton::clicked, this, [=]() {
406 QString optionValue = checked[i];
407 this->showExtcapOptionsDialogForOptionValue(item, optionValue);
408 });
409 }
410 else
411 {
412 tableViewModel->appendRow(item);
413 }
414 }
415
416 if (tableView->horizontalHeader()->count() > 0)
417 {
418 // Qt <6.9 bug (fixed in 6.9): setting the ResizeMode of a column before it has at least 1 element
419 // will make a segfault.
420 tableView->resizeColumnToContents(1);
421 tableView->horizontalHeader()->setSectionResizeMode(0, QHeaderView::Stretch);
422 if (_argument->configurable)
423 tableView->horizontalHeader()->setSectionResizeMode(1, QHeaderView::ResizeToContents);
424 }
425}
426
427void ExtArgTable::setDefaultValue()
428{
429 QStringList checked;
430
431 if (tableViewModel == 0)
432 return;
433
434 tableViewModel->clear();
435 checked = defaultValue().split(",", Qt::SkipEmptyParts);
436 addChecked(checked, QStringList());
437}
438
439void ExtArgTable::addKnown()
440{
441 // Un-select everything in the selector: it's a new day.
442 QStringList checked;
443 for (int row = 0; row < viewModel->rowCount(); row++)
444 checkItemsWalker(((QStandardItemModel*)viewModel)->item(row), checked);
445
446 // Display "add" popup
447 if (addDialog->exec() == QDialog::Accepted)
448 {
449 checked = ExtArgMultiSelect::checkedValues();
450 addChecked(checked, QStringList());
451 }
452}
453
454void ExtArgTable::addCustom()
455{
456 // Prompt for custom input
457 bool ok;
458 QString text = QInputDialog::getText(
459 tableView,
460 tr("Add custom data"),
461 tr("Custom:"),
462 QLineEdit::Normal,
463 "",
464 &ok
465 );
466 if (ok && !text.isEmpty())
467 {
468 addChecked({ text }, QStringList());
469 }
470}
471
472void ExtArgTable::removeSelected()
473{
474 // Get current selection
475 QModelIndexList selected = tableView->selectionModel()->selectedIndexes();
476
477 // Remove them from list
478 for (int row = 0; row < selected.size(); row++)
479 tableViewModel->removeRow(selected[row].row());
480}
481
482void ExtArgTable::showExtcapOptionsDialogForOptionValue(QStandardItem* item, QString& option_value)
483{
484 QString device_name(_argument->device_name);
485 QString option_name(_argument->call + 2); /* skip -- */
486 extcap_options_dialog = ExtcapOptionsDialog::createForDevice(device_name, false, tableView->parentWidget(),
487 &option_name, &option_value);
488 /* The dialog returns null, if the given device name is not a valid extcap device */
489 if (extcap_options_dialog) {
490 extcap_options_dialog->setModal(true);
491 extcap_options_dialog->setAttribute(Qt::WA_DeleteOnClose);
492 connect(extcap_options_dialog, &ExtcapOptionsDialog::accepted, this, [=]() {
493 this->extcap_suboptions_accepted(item);
494 });
495 extcap_options_dialog->show();
496 }
497}
498
499QString
500extcap_format_external_arguments(GHashTable* extcap_args)
501{
502 QString command_line;
503
504 GHashTableIter iter;
505 void *key, *value;
506 g_hash_table_iter_init(&iter, extcap_args);
507 while (g_hash_table_iter_next(&iter, &key, &value)) {
508 if (key != NULL__null)
509 {
510 command_line.append(g_strdup((char*)key)g_strdup_inline ((char*)key));
511 command_line.append(" ");
512 }
513 if (value != NULL__null)
514 {
515 command_line.append(g_strdup((char*)value)g_strdup_inline ((char*)value));
516 command_line.append(" ");
517 }
518 }
519
520 return command_line;
521}
522
523void ExtArgTable::extcap_suboptions_accepted(QStandardItem* item)
524{
525 QString arguments = extcap_format_external_arguments(extcap_options_dialog->getExtcapArgumentSettings());
526 item->setData(arguments, Qt::UserRole + 1);
527}